[PATCH] Fix for bug 22941, [asm inline] integer template parameter ...

Sunil Srivastava Sunil_Srivastava at playstation.sony.com
Wed Jun 24 16:35:30 PDT 2015


ping


================
Comment at: lib/Sema/SemaStmtAsm.cpp:257
@@ -256,3 +256,2 @@
     } else if (Info.requiresImmediateConstant() && !Info.allowsRegister()) {
       llvm::APSInt Result;
-      if (!InputExpr->EvaluateAsInt(Result, Context))
----------------
majnemer wrote:
> I think we could just fix this by inserting:
>   if (InputExpr->isValueDependent())
>     continue;
Just that does not work because the 'continue' skips needed code later inside the loop body, leading to assertion failures, on the windows build at least.

However, wrapping whole 10 line checking code in a (!InputExpr->isValueDependent()) works. I am updating the review to reflect that.

http://reviews.llvm.org/D10452

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list