[PATCH] Relax assertion in x86_64 byval argument handling for 32-bit pointers

Jan Voung jvoung at chromium.org
Wed Jun 24 14:04:51 PDT 2015


================
Comment at: lib/CodeGen/TargetInfo.cpp:2501
@@ -2500,3 +2500,3 @@
   if (HiStart != 8) {
     // There are only two sorts of types the ABI generation code can produce for
     // the low part of a pair that aren't 8 bytes in size: float or i8/i16/i32.
----------------
For the old "two sorts of types..." comment, technically a pointer type is still a separate type from i8/i16/i32, so it would be worth updating the comment for x32 pointers.

I assume that the rest of the code knows how to cast a pointer type to the wider i64 type.

http://reviews.llvm.org/D10701

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list