[PATCH] libc++: Make support for thread-unsafe C functions optional

Ed Schouten ed at nuxi.nl
Wed Jun 24 01:50:29 PDT 2015


In http://reviews.llvm.org/D8703#192868, @mclow.lists wrote:

> Except for the bit in locale.cpp, these changes look OK to me.


Thanks for the review!

Regarding the change to locale.cpp: CloudABI does not have setlocale(), which is why this call would need to be disabled. libc++ still has a global locale, but it's not the case that this is propagated to the C runtime.

I've reverted this part of the change for now, as we could argue it's not related to the change at hand. I suspect it may make more sense to `#ifndef __CloudABI__` that part at one point.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8703

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list