[PATCH] libc++: Make support for thread-unsafe C functions optional

Marshall Clow mclow.lists at gmail.com
Tue Jun 23 08:32:07 PDT 2015


Except for the bit in locale.cpp, these changes look OK to me.

I'm concerned about the proliferation of "subsets" of the libc++ functionality (no threads, no filesystem, no thread-unsafe fns), but ...


================
Comment at: src/locale.cpp:579
@@ -578,2 +578,3 @@
+#ifndef _LIBCPP_HAS_NO_THREAD_UNSAFE_C_FUNCTIONS
     if (g.name() != "*")
         setlocale(LC_ALL, g.name().c_str());
----------------
Unlike all the other changes, this is a behavior change.

http://reviews.llvm.org/D8703

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list