[PATCH] Improved checking for repeated macro argument with side effects when macro contains ?:

Daniel Marjamäki daniel.marjamaki at evidente.se
Tue Jun 23 07:25:45 PDT 2015


Hi alexfh,

This patch fixes possible false negatives when macro contains ?:.

I tested this improvemed checker on 1398 open source projects, but did not see any new warnings.. At least that means that it did not cause any new false positives even though it does fix the false negatives that are shown in the testing.

Question: Is it a good idea to use std::stack or would some other container be better in clang-tidy?

http://reviews.llvm.org/D10653

Files:
  clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp
  test/clang-tidy/misc-repeated-side-effects-in-macro.c

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10653.28240.patch
Type: text/x-patch
Size: 4034 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150623/94ac4316/attachment.bin>


More information about the cfe-commits mailing list