[PATCH] Mark libm builtins as such.

Renato Golin renato.golin at linaro.org
Tue Jun 23 05:05:14 PDT 2015


Hi Charlie,

I think this looks ok, but can you enlighten me a bit?

>From what I read here [1], these builtins can be compiler replacements for library functions, especially if they have the "__builtin" prefix:

  "... may be handled as built-in functions. All these functions have corresponding versions prefixed with __builtin_ ..."

And from the bug report [2], what Android needs is for it to be re-declared differently, and that's why you're adding them as library calls, so that can happen.

Is then, this patch ultimately linked to http://reviews.llvm.org/D9912? Or does this make sense on its own? If it does, I'm failing to see why. :)

cheers,
--renato

[1] https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
[2] https://llvm.org/bugs/show_bug.cgi?id=20958


http://reviews.llvm.org/D9913

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list