[PATCH] Pedantically rename all Tool subclasses to be nouns, not verbs. NFC

Douglas Katzman dougk at google.com
Mon Jun 22 08:03:46 PDT 2015


================
Comment at: lib/Driver/Tools.h:170
@@ -171,1 +169,3 @@
+    Compiler(const ToolChain &TC)
+        : Common("gcc::Compile", "gcc frontend", TC) {}
 
----------------
chandlerc wrote:
> Above you renamed "gcc::Preprocess" to "gcc::Preprocessor", but here (and almost everywhere else in my spot check) the text names were left alone.
> 
> I'm not actually sure which is right. These seem like documentation or logging generation strings, so maybe they should all be updated?
a few of these strings are tested for in 'lit' tests, so I wanted to avoid changing them; but that was just undue paranoia. I put a cautionary note at the one that matters - "clang" must remain literally as-is; and changed others.

http://reviews.llvm.org/D10595

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list