[PATCH] Pedantically rename all Tool subclasses to be nouns, not verbs. NFC

Chandler Carruth chandlerc at gmail.com
Sun Jun 21 19:25:48 PDT 2015


================
Comment at: lib/Driver/Tools.h:170
@@ -171,1 +169,3 @@
+    Compiler(const ToolChain &TC)
+        : Common("gcc::Compile", "gcc frontend", TC) {}
 
----------------
Above you renamed "gcc::Preprocess" to "gcc::Preprocessor", but here (and almost everywhere else in my spot check) the text names were left alone.

I'm not actually sure which is right. These seem like documentation or logging generation strings, so maybe they should all be updated?

http://reviews.llvm.org/D10595

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list