[PATCH] [Clang Static Analyzer] Bug identification

[Honggyu Kim]

Hi, I've tried to write the same feature for HTML report generation by inserting line number 547-550 of PlistDiagnostics.cpp to HTMLDiagnostics.cpp. But GetIssueHash() and related functions are too much binded to PlistDiagnostics.cpp even though they are not member functions of class PlistDiagnostics.
So I would like to gently ask you to move GetIssueHash() and related functions to the outside of PlistDiagnostics.cpp.
Otherwise, please let me know if you have any other plan to put BugID for HTML report in a different way.

Honggyu


================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:296
@@ -287,1 +295,3 @@
 
+static std::string GetSignature(const clang::FunctionDecl *Target) {
+  if (!Target)
----------------
Ditto.

================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:371
@@ +370,3 @@
+
+static std::string GetEnclosingDeclContextSignature(const Decl *D) {
+  if (!D)
----------------
Ditto.

================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:403
@@ +402,3 @@
+
+static std::string GetNthLineOfFile(llvm::MemoryBuffer *Buffer, int Line) {
+  if (!Buffer)
----------------
Ditto.

================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:414
@@ +413,3 @@
+
+static llvm::SmallString<32> GetHashOfContent(StringRef Content) {
+  llvm::MD5 Hash;
----------------
Ditto.

================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:429
@@ +428,3 @@
+                                          StringRef CheckerName,
+                                          StringRef HashField, const Decl *D) {
+  static llvm::StringRef Delimiter = "$";
----------------
Ditto.

================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:550
@@ +549,3 @@
+    EmitString(o, GetIssueHash(SM, L, D->getCheckName(), D->getHashField(),
+                               DeclWithIssue).str()) << '\n';
+
----------------
Can we move GetIssueHash() and related function to outside of PlistDiagnostics.cpp?

http://reviews.llvm.org/D10305

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/