[PATCH] [modules] PR20507: Avoid silent textual inclusion.
chisophugis at gmail.com
Fri Jun 12 15:29:43 PDT 2015
Hi rsmith, benlangmuir, djasper,
This pretty naively follows the implementation suggested by Richard.
I'd like to switch these over to be fatal errors (since they are
essentially similar to err_pp_file_not_found), but I'm still investigating
some test failures that happen when I switched them over.
I'm really not a fan of the `M->isAvailable(getLangOpts(), getTargetInfo(),
Requirement, MissingHeader)` function; it seems to do too many things at
once, but for now I've done things in a sort of awkward way.
The changes to test/Modules/Inputs/declare-use/module.map
were necessitated because the thing that was meant to be tested there
(introduced in r197805) was predicated on silently falling back to textual
inclusion, which we no longer do.
The changes to test/Modules/Inputs/macro-reexport/module.modulemap
are just an overlooked missing header that seems to have been missing since
this code was committed (r213922), which is now caught.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4861 bytes
Desc: not available
More information about the cfe-commits