[PATCH] Allow case-insensitive values for -mcpu for AArch64 target in line with GCC.
richard.barton at arm.com
Fri Jun 12 09:22:04 PDT 2015
I have one comment about a missing regression test, but otherwise this patch seems fine to me. I understand the previous version broke the ARM bot, so I will let Renato have last say.
Comment at: test/Driver/aarch64-cpus.c:114
@@ -113,1 +113,3 @@
+// ================== Check whether -mcpu accepts mixed-case values.
+// RUN: %clang -target aarch64 -mcpu=Cortex-a53 -### -c %s 2>&1 | FileCheck -check-prefix=CASE-INSENSITIVE-CA53 %s
It seems your patch also allows mixed case in the +feature part of the argument. This is in line with GCC 4.9, but I would expect a regression test checking that here.
More information about the cfe-commits