[PATCH] [Parse] Allow 'constexpr' in condition declarations

Meador Inge meadori at gmail.com
Thu Jun 11 09:27:50 PDT 2015


Here is a new version with the previous feedback incorporated:

1. Use 'DSC_condition' instead of 'DSC_constexpr'.

2. Delay applying `ActOnFinishFullExpr' until all switch conditions are done.  I ended up unconditionally adding `ActOnFinishFullExpr' for the if, for, while, and switch cases.  There is a small amount of duplication, but it makes the code easier to follow since you don't have to think about under what conditions the call happens (and I personally found it difficult to understand why it was conditional with 'switch' to begin with).  Also, it seems to be common practice to directly call `ActOnFinishFullExpr' in a lot of the other Sema implementation pieces.


http://reviews.llvm.org/D8978

Files:
  lib/Target/AArch64/AArch64TargetMachine.cpp
  lib/Target/ARM/ARMTargetMachine.cpp
  lib/Target/Mips/MipsTargetMachine.cpp
  lib/Target/R600/AMDGPUTargetMachine.cpp
  lib/Target/SystemZ/SystemZTargetMachine.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8978.27520.patch
Type: text/x-patch
Size: 7515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150611/8421c3e0/attachment.bin>


More information about the cfe-commits mailing list