[PATCH] Save getArch() in a local var instead of calling it 20 times, etc.

Douglas Katzman dougk at google.com
Wed Jun 3 15:44:27 PDT 2015


================
Comment at: lib/Driver/Tools.cpp:7816
@@ -7819,1 +7815,3 @@
+  else if (Arch == llvm::Triple::ppc64) {
+    if (ppc::hasPPCAbiArg(Args, "elfv2")) return "/lib64/ld64.so.2";
     return "/lib64/ld64.so.1";
----------------
jroelofs wrote:
> return should be on next line.
Done.

================
Comment at: lib/Driver/Tools.cpp:7819
@@ -7823,1 +7818,3 @@
+  } else if (Arch == llvm::Triple::ppc64le) {
+    if (ppc::hasPPCAbiArg(Args, "elfv1")) return "/lib64/ld64.so.1";
     return "/lib64/ld64.so.2";
----------------
jroelofs wrote:
> return should be on next line.
Done.

================
Comment at: lib/Driver/Tools.cpp:7939
@@ +7938,3 @@
+  if (Arch == llvm::Triple::armeb || Arch == llvm::Triple::thumbeb)
+    arm::appendEBLinkFlags(
+        Args, CmdArgs,
----------------
jroelofs wrote:
> why are you changing the format of this line?
clang-format likes it this way. Should it be forced back the way it was?

http://reviews.llvm.org/D10224

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list