[PATCH] Fix Bug 23189 in C++14 type inference for lambdas with undeclared identifiers

[Kaelyn Takata]

Barring a test case that should successfully perform typo correction, the
change seems reasonable for avoiding the null pointer dereference. My only
nit is that it would be better to have both test cases in the same file (or
even better, in an existing test file with their own enclosing namespace,
if there is an appropriate file for it) instead of adding two more files
since there is already so many test case files, and IMHO having all the
test cases for the same code path in the same file makes it easier to keep
track of the test cases.

On Mon, Jun 1, 2015 at 12:33 PM, Richard Smith <richard at metafoo.co.uk>
wrote:

> Kaelyn, should we do typo correction sooner here?
> On 1 Jun 2015 11:41 am, "Dimitry Andric" <dimitry at andric.com> wrote:
>
>> It looks good to me, and it fixes both the original test case in bug
>> 23189, and the reduced test case I added there.
>>
>>
>> http://reviews.llvm.org/D9880
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150601/4d39bd19/attachment.html>