Change const std::string & to StringRef in Lexer

Rafael Espíndola rafael.espindola at gmail.com
Mon Jun 1 13:05:27 PDT 2015


I committed them as r238774 and r238775.

Thanks,
Rafael


On 1 June 2015 at 12:52, Косов Евгений <claprix at yandex.ru> wrote:
> Sorry for my inattension.
>
> I actually have 2 patches for clang Lex and for clang-tools-extra which build needs to be fixed after applying the first patch.
>
> 01.06.2015, 17:12, "Rafael Espíndola" <rafael.espindola at gmail.com>:
>> For the first few patches you just ask someone to commit it.
>>
>> In this case, two things I noticed when I applied the patch:
>>
>> * It is for clang, so you should send it to cfe-commits.
>> * It is incomplete. Looks like you only included the header changes:
>>
>> llvm/tools/clang/lib/Lex/PTHLexer.cpp:434:25: error: out-of-line
>> definition of 'Create' does not match any declaration in
>> 'clang::PTHManager'
>> PTHManager *PTHManager::Create(const std::string &file,
>>
>> On 1 June 2015 at 02:27, Косов Евгений <claprix at yandex.ru> wrote:
>>>  Cool. Thanks for reviewing. How now can I commit this patch into trunk?
>>>
>>>  Eugene
>>>
>>>  01.06.2015, 03:12, "Rafael Espíndola" <rafael.espindola at gmail.com>:
>>>>  LGTM
>>>>
>>>>  On 31 May 2015 at 15:56, Косов Евгений <claprix at yandex.ru> wrote:
>>>>>   Hi.
>>>>>
>>>>>   This is a small and boring patch. I'm checking a patch submitting process. Does it make sense to change more const string references in other part of LLVM?
>>>>>
>>>>>   Eugene
>>>>>   _______________________________________________
>>>>>   llvm-commits mailing list
>>>>>   llvm-commits at cs.uiuc.edu
>>>>>   http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> Eugene




More information about the cfe-commits mailing list