[PATCH] Fix PR21945

Косов Евгений claprix at yandex.ru
Mon Jun 1 09:33:11 PDT 2015


Thanks!

01.06.2015, 19:27, "Jonathan Roelofs" <jonathan at codesourcery.com>:
> On 6/1/15 10:19 AM, Jonathan Roelofs wrote:
>>  On 6/1/15 9:42 AM, Косов Евгений wrote:
>>>  01.06.2015, 17:31, "Jonathan Roelofs" <jonathan at codesourcery.com>:
>>>>  +cfe-commits
>>>>
>>>>  On 6/1/15 7:56 AM, Косов Евгений wrote:
>>>>>    Hello.
>>>>>
>>>>>    https://llvm.org/bugs/show_bug.cgi?id=21945
>>>>>    Fix is simple - do not enter in a loop body iterating an empty
>>>>>  container.
>>>>  Going forward, Clang patches should be sent to cfe-commits at cs.uiuc.edu.
>>>  Thanks for the info.
>>>>  Also, please upload patches with more context (i.e. `git diff -U999`).
>>>  Why so much? Because you don't apply patch but just read through it?
>>  Mostly because it makes review over email easier, especially if the
>>  patch has been posted via phabricator.
>>>>>    If the patch is ok how can it be committed into trunk?
>>>>  While you're here, mind putting an llvm_unreachable after the loop body?
>>>  Sure, why not?
>>  Thanks.
>>>>>    Do I need to sign something?
>>>>  No. You can get commit access by following:
>>>>  http://llvm.org/docs/DeveloperPolicy.html#id16, or one of us can commit
>>>>  it for you after you've got a "LGTM" on it.
>>>  For now I don't need commit rights. So if my patch is ok please commit
>>>  it.
>>  LGTM. I'll build/test/commit shortly.
>
> Committed in r238758.
>>  Jon
>>>>  Cheers,
>>>>
>>>>  Jon
>>>>>    Eugene
>>>>>
>>>>>    _______________________________________________
>>>>>    llvm-commits mailing list
>>>>>    llvm-commits at cs.uiuc.edu
>>>>>    http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>  --
>>>>  Jon Roelofs
>>>>  jonathan at codesourcery.com
>>>>  CodeSourcery / Mentor Embedded
>>>  Eugene
>
> --
> Jon Roelofs
> jonathan at codesourcery.com
> CodeSourcery / Mentor Embedded

Eugene




More information about the cfe-commits mailing list