[PATCH] Embed Windows version resource information into our exe and dll files

[Greg Bedwell]

Thanks for the review!  Unfortunately I had to revert again in r238744 as
it failed when doing a clang-cl self-host build.  This feature is
determined to send me down as many rabbit holes as possible.  Thankfully
I've now managed to reproduce that failure locally so I'm investigating
what's going on.

What I've figured out so far is that CMake's cmcldeps tool is failing when
that is handed clang-cl.exe as a program argument instead of cl.exe so I
suspect I've stumbled onto a legitimate compatibility issue between cl and
clang-cl. According to the source code I found at
https://github.com/Kitware/CMake/blob/master/Source/cmcldeps.cxx its
purpose is:

// Wrapper around cl that adds /showIncludes to command line, and uses that
to
// generate .d files that match the style from gcc -MD.

The first failure I ran into was that cmcldeps appears to be specifying the
output file with "/out:<filename>" which clang-cl interprets as "/o"
"ut:<filename>", but after hacking in support for that locally I'm still
running into another failure later on.  I think the next step is to rebuild
cmcldeps.exe myself with some more useful logging so I'll continue on that
tomorrow and hopefully have an update soon.

Thanks again,
-Greg






On 1 June 2015 at 13:46, Greg Bedwell <greg_bedwell at sn.scee.net> wrote:

> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D7828
>
> Files:
>   llvm/trunk/cmake/modules/AddLLVM.cmake
>   llvm/trunk/resources/windows_version_resource.rc
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150601/e0798765/attachment.html>