r238389 - [omp] Re-work Clang's handling of -fopenmp and undo r237769.

Chandler Carruth chandlerc at gmail.com
Thu May 28 13:48:37 PDT 2015


On Thu, May 28, 2015 at 5:09 AM İsmail Dönmez <ismail at donmez.ws> wrote:

> Hi,
>
> On Thu, May 28, 2015 at 4:52 AM, Chandler Carruth <chandlerc at gmail.com>
> wrote:
> > Author: chandlerc
> > Date: Wed May 27 20:52:38 2015
> > New Revision: 238389
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=238389&view=rev
> > Log:
> > [omp] Re-work Clang's handling of -fopenmp and undo r237769.
>
>
> This seems to break openmp tests with
> -DCLANG_DEFAULT_OPENMP_RUNTIME=libiomp5 see:
>

Yea, I wanted to have test coverage of the default, but it doesn't work
well when the default is overridden.

I looked into how to actually have test coverage of the default and track
which default was selected, but its really hard and complex. Yuck.

I'll look for a way to get at least *some* coverage of the default without
making it break folks that are overriding it. Sorry for the trouble.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150528/e22aabe1/attachment.html>


More information about the cfe-commits mailing list