[PATCH] [CodeGen] Reuse stack space from unused function results (with more accurate unused result detection)

Reid Kleckner rnk at google.com
Wed May 27 13:04:43 PDT 2015


I don't think this is the right approach. The code that you're reusing is in theory checking the same thing as codegen, but the implementations are distant, unrelated, and I suspect out of sync. I think this will probably be easier to handle in AggExprEmitter, which has more accurate information about its destinations.

You might also want to use the cleanup mechanism instead of trying to manually insert IR after emitting the function call. We should probably add a helper for pushing a CallLifetimeEnd cleanup that takes the slot address and size.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10042

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list