[PATCH] Fix for #pragma warning to work correctly with "1-4:" specifiers

Andrey Bokhanko andreybokhanko at gmail.com
Thu May 21 05:57:18 PDT 2015


================
Comment at: test/Preprocessor/pragma_microsoft_E.c:83
@@ +82,3 @@
+// Test that we parsed all pragmas successfully and not produced any warnings
+// CHECK-NOT: warning:
+
----------------
rnk wrote:
> You should check that the warning pragmas roundtrip through the preprocessor, though.
Reid, sorry for a noob question -- what do you mean by checking "roundtrip through the preprocessor"? Is there an existing test I can use as an example?

In the updated patch I added CHECKs for preprocessor's output -- is this what you meant?

http://reviews.llvm.org/D9856

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list