[PATCH] [ARM] Restructure cpu handling in the driver to mostly use the triple

Renato Golin renato.golin at linaro.org
Wed May 20 10:56:38 PDT 2015

Hi John,

The changes look fine with two comments. Don't worry too much if ARMTargetParser is a bit confusing, once we got all arch / cpu changes into it, I'll refactor it to make more sense. For now, I'm trying hard to not change the behaviour in any way.



Comment at: lib/Driver/Tools.cpp:620
@@ -619,1 +619,3 @@
+static int getARMSubArchVersionNumber(const llvm::Triple &Triple) {
+  switch (Triple.getSubArch()) {
These two should either go into Triple or ARMTargetParser. I'll do that move later, for now, they can stay here. Just add a comment:

    // FIXME: Move to ARMTargetParser.

Comment at: lib/Driver/Tools.cpp:780
@@ -750,3 +779,3 @@
-  // -march is handled in getARMCPUForMarch by translating it into a CPU name,
+  // -march is handled in getARMCPUForMArch by translating it into a CPU name,
   // but it needs to return an empty string on invalid arguments. We therefore
Not any more. Check ARMTargetParser::getCanonicalArch() and parseArch().



More information about the cfe-commits mailing list