Fw: [PATCH] Fix invalid code generation (regression) in pass-by-value on PPC32

Reid Kleckner rnk at google.com
Mon May 18 11:08:31 PDT 2015

On Sun, May 17, 2015 at 1:26 PM, Andy Gibbs <andyg1001 at hotmail.co.uk> wrote:

> Reid,
> I'm forwarding this onto you since you are the original committer for
> r208733
> which I wish to partially revert.  The patch is attached and full(er)
> details
> can be found at the bug report (link below).  Sorry for sending it to two
> email addresses, but I don't know which is your active one.
> I think you simply factored out code block too many, where (if I understand
> your intentions correctly) you were factoring out the common code for
> *ABI*::classifyReturnType but unintentionally included
> DefaultABIInfo::classifyArgumentType, breaking ppc32 code generation.
> Please can you review my patch to be sure I haven't done anything stupid
> before I commit it.

Yeah, it looks like the refactor went awry. I'm concerned that PPC32 is
relying on DefaultABIInfo and that no test caught this. I'll go ahead and
apply that, thanks for the patch!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150518/7038e79e/attachment.html>

More information about the cfe-commits mailing list