[PATCH] Enhance clang-tidy readability-simplify-boolean-expr to handle 'if (e) return true; return false; '

Richard legalize at xmission.com
Mon May 18 08:28:10 PDT 2015

In http://reviews.llvm.org/D9810#174211, @alexfh wrote:

> In http://reviews.llvm.org/D9810#173999, @LegalizeAdulthood wrote:
> > In http://reviews.llvm.org/D9810#173989, @LegalizeAdulthood wrote:
> >
> > > Testing this on LLVM/clang indicates that it turns valid code into invalid code, so I will need to address this first.  The problem appears that isFollowedBy is reporting `true` when it should not.
> >
> >
> > This appears to be a regression somewhere outside of my changes.
> So does LLVM/Clang compile and pass all tests after applying all fixes from this check?

It all compiles, but manual testing with clang-query shows the problem.  See https://llvm.org/bugs/show_bug.cgi?id=23552 for details.



More information about the cfe-commits mailing list