Add =ON to cmake flag definition

Albert Astals Cid albert.astals at canonical.com
Sun May 17 20:54:40 PDT 2015


On Mon, May 18, 2015 at 4:37 AM, Justin Bogner <mail at justinbogner.com> wrote:
> Albert Astals Cid <albert.astals at canonical.com> writes:
>> Hi, i think it'd make sense to specify the full command you have to
>> write to command line so one can just copy&paste from the
>> documentation.
>
> Seems reasonable. Do you need somebody to commit this for you?

Yes please.

Cheers,
  Albert

>
>> Please CC me i'm not on the list
>>
>> Cheers,
>>   Albert
>>
>> Index: docs/ModernizerUsage.rst
>> ===================================================================
>> --- docs/ModernizerUsage.rst  (revision 236973)
>> +++ docs/ModernizerUsage.rst  (working copy)
>> @@ -38,7 +38,7 @@
>>    ``<build-path>`` is the directory containing a *compilation databasefile*, a
>>    file named ``compile_commands.json``, which provides compiler arguments for
>>    building each source file. CMake can generate this file by specifying
>> -  ``-DCMAKE_EXPORT_COMPILE_COMMANDS`` when running CMake. Ninja_, since v1.2 can
>> +  ``-DCMAKE_EXPORT_COMPILE_COMMANDS=ON`` when running CMake. Ninja_, since v1.2 can
>>    also generate this file with ``ninja -t compdb``. If the compilation database
>>    cannot be used for any reason, an error is reported.
>>
>> Index: docs/clang-modernize.rst
>> ===================================================================
>> --- docs/clang-modernize.rst  (revision 236973)
>> +++ docs/clang-modernize.rst  (working copy)
>> @@ -51,7 +51,7 @@
>>  A `compilation database`_ contains the command-line arguments for multiple
>>  files. If the code you want to transform can be built with CMake, you can
>>  generate this database easily by running CMake with the
>> -``-DCMAKE_EXPORT_COMPILE_COMMANDS`` option. The Ninja_ build system, since
>> +``-DCMAKE_EXPORT_COMPILE_COMMANDS=ON`` option. The Ninja_ build system, since
>>  v1.2, can create this file too using the *compdb* tool: ``ninja -t compdb``. If
>>  you're not already using either of these tools or cannot easily make use of
>>  them you might consider looking into Bear_.
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list