[PATCH] add the -mrecip driver flag and process its options

hfinkel at anl.gov hfinkel at anl.gov
Thu May 14 13:02:11 PDT 2015


================
Comment at: lib/Driver/Tools.cpp:1633
@@ +1632,3 @@
+    D.Diag(diag::err_drv_argument_not_allowed_with)
+      << A->getOption().getName() << "Too many options specified.";
+  }
----------------
You should either accept duplicates, or provide a specific error on the duplicated keys. Don't just complain about the number, that's not informative.


================
Comment at: lib/Driver/Tools.cpp:1662
@@ +1661,3 @@
+    // Ignore the '-' or optional '+' in string comparison.
+    bool IsNegative = (Val[0] == '-');
+    if (IsNegative)
----------------
Why can these be negative?

http://reviews.llvm.org/D8989

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list