[clang-tools-extra] r237116 - Fix misleading parameter name for PPCallbacks::FileSkipped.

Nikola Smiljanic popizdeh at gmail.com
Tue May 12 04:48:21 PDT 2015


Author: nikola
Date: Tue May 12 06:48:21 2015
New Revision: 237116

URL: http://llvm.org/viewvc/llvm-project?rev=237116&view=rev
Log:
Fix misleading parameter name for PPCallbacks::FileSkipped.

Patch thanks to Vladimir Voskresensky.

Modified:
    clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp
    clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h

Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp?rev=237116&r1=237115&r2=237116&view=diff
==============================================================================
--- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp (original)
+++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp Tue May 12 06:48:21 2015
@@ -111,11 +111,11 @@ void PPCallbacksTracker::FileChanged(
 // Callback invoked whenever a source file is skipped as the result
 // of header guard optimization.
 void
-PPCallbacksTracker::FileSkipped(const clang::FileEntry &ParentFile,
+PPCallbacksTracker::FileSkipped(const clang::FileEntry &SkippedFile,
                                 const clang::Token &FilenameTok,
                                 clang::SrcMgr::CharacteristicKind FileType) {
   beginCallback("FileSkipped");
-  appendArgument("ParentFile", &ParentFile);
+  appendArgument("ParentFile", &SkippedFile);
   appendArgument("FilenameTok", FilenameTok);
   appendArgument("FileType", FileType, CharacteristicKindStrings);
 }

Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h?rev=237116&r1=237115&r2=237116&view=diff
==============================================================================
--- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h (original)
+++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h Tue May 12 06:48:21 2015
@@ -84,7 +84,7 @@ public:
                    clang::PPCallbacks::FileChangeReason Reason,
                    clang::SrcMgr::CharacteristicKind FileType,
                    clang::FileID PrevFID = clang::FileID()) override;
-  void FileSkipped(const clang::FileEntry &ParentFile,
+  void FileSkipped(const clang::FileEntry &SkippedFile,
                    const clang::Token &FilenameTok,
                    clang::SrcMgr::CharacteristicKind FileType) override;
   bool FileNotFound(llvm::StringRef FileName,





More information about the cfe-commits mailing list