[PATCH] [cuda] Include GPU binary into host object file and generate init/deinit code.

Eli Bendersky eliben at google.com
Wed May 6 08:44:51 PDT 2015


LGTM

[assuming this just copies stuff from http://reviews.llvm.org/D8463 w/o modifications]


================
Comment at: lib/CodeGen/CGCUDANV.cpp:43
@@ +42,3 @@
+  llvm::SmallVector<llvm::Function *, 16> EmittedKernels;
+  /// Keeps track of variables containing handles of GPU binaries Populated by
+  /// ModuleCtorFunction() and used to create corresponding cleanup calls in
----------------
Nit: period (or semicolon) after "binaries"?

http://reviews.llvm.org/D9507

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list