r236423 - [analyzer] scan-build: support spaces in compiler path and arguments.

Anton Yartsev anton.yartsev at gmail.com
Wed May 6 04:44:12 PDT 2015


Hi Ahmed,

I went ahead and reverted this in r236562.  I believe the first part
> is fine, but I don't see why you need the second part:  from what I've
> seen, clang -### generates the line, and it always single-quotes
> everything.  When are spaces a problem there?
>

Later in ccc-analyzer all quotes and backslashesare are removed by the call
to "quotewords('\s+', 0, $line)".

The problem first occurred when I tried to use clang compiled by VS.
Running scan-build ended up with:
...
#SHELL (cd ... && 'clang++.exe' '-cc1' '-triple' 'i686-pc-windows-msvc'
'-analyze' ... '-internal-isystem' 'C:\Program Files\Microsoft Visual
Studio 11.0\VC\include' ... 'file.cpp')
error: error reading 'Files\Microsoft'
error: error reading 'Visual'
error: error reading 'Studio'
error: error reading '11.0\VC\include'
4 errors generated.

Thanks for reverting the commit. I'll try to restrict the fix only on -I
option.

-- 
Kind regards,
Yartsev Anton
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150506/ae0843b5/attachment.html>


More information about the cfe-commits mailing list