r236562 - Revert "[analyzer] scan-build: support spaces in compiler path and arguments."

Ahmed Bougacha ahmed.bougacha at gmail.com
Tue May 5 19:08:27 PDT 2015


Author: ab
Date: Tue May  5 21:08:27 2015
New Revision: 236562

URL: http://llvm.org/viewvc/llvm-project?rev=236562&view=rev
Log:
Revert "[analyzer] scan-build: support spaces in compiler path and arguments."

This reverts commit r236423 and its followup r236533, as indiscriminate
quoting makes for too much quoting (and clang doesn't like both '"-c"'
and -D"FOO=bar").

Modified:
    cfe/trunk/tools/scan-build/ccc-analyzer

Modified: cfe/trunk/tools/scan-build/ccc-analyzer
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/scan-build/ccc-analyzer?rev=236562&r1=236561&r2=236562&view=diff
==============================================================================
--- cfe/trunk/tools/scan-build/ccc-analyzer (original)
+++ cfe/trunk/tools/scan-build/ccc-analyzer Tue May  5 21:08:27 2015
@@ -145,7 +145,7 @@ sub ProcessClangFailure {
   print OUT "@$Args\n";
   close OUT;
   `uname -a >> $PPFile.info.txt 2>&1`;
-  `"$Compiler" -v >> $PPFile.info.txt 2>&1`;
+  `$Compiler -v >> $PPFile.info.txt 2>&1`;
   rename($ofile, "$PPFile.stderr.txt");
   return (basename $PPFile);
 }
@@ -180,10 +180,6 @@ sub GetCCArgs {
   # Strip leading and trailing whitespace characters.
   $line =~ s/^\s+|\s+$//g;
   my @items = quotewords('\s+', 0, $line);
-  # Wrap arguments that have spaces with quotes.
-  foreach (@items) {
-    $_ = qq/"$_"/ if (/\s+/);
-  }
   my $cmd = shift @items;
   die "cannot find 'clang' in 'clang' command\n" if (!($cmd =~ /clang/));
   return \@items;





More information about the cfe-commits mailing list