3.6.1 nominations for libc++abi

Jonathan Roelofs jonathan at codesourcery.com
Mon May 4 12:17:50 PDT 2015



On 5/4/15 1:10 PM, Tom Stellard wrote:
> On Sat, May 02, 2015 at 07:05:29PM -0400, Eric Fiselier wrote:
>> Hi Tom,
>> CC Marshall
>>
>
> Is Marshall the code owner for these?

Yes.

The first two look fine to merge to me. I don't feel confident enough to 
say anything about the latter three.


Jon

>
> -Tom
>
>> I nominate the following patches to be included in 3.6.1.
>>
>> These two commits clean up undefined behavior in readEncodedPointer.
>>
>> - r231839: Fix PR21580 - Undefined behavior in readEncodedPointer()
>>    https://llvm.org/bugs/show_bug.cgi?id=21580
>>    https://github.com/llvm-mirror/libcxxabi/commit/89ea9ad0b0a48a9b9fccf6de81bdca1861960855
>>
>> - r231852: Remove unneeded const_cast in readPointerHelper. Pointed
>> out by jroelofs
>>    https://github.com/llvm-mirror/libcxxabi/commit/fdd39fd838828bba84c4f7ad620207ae0d734ad5
>>
>>
>> These commits how libc++abi matches exception types to catch blocks.
>> In particular it makes libc++abi properly check for multilevel pointer
>> conversions as well as void* conversions.
>>
>>
>> - r233984: Fix multi-level pointer conversions and pointer to member
>> conversion detection.
>>    https://github.com/llvm-mirror/libcxxabi/commit/0cb62d1b51f3d9ab65e0ba7b6541dda0663fe50d
>>
>> - r234254: Disallow Base to Derived conversions for catching pointers
>> to members.
>>    https://github.com/llvm-mirror/libcxxabi/commit/554d59ab0b989830273c9183f7bdfd12108cad7a
>>
>> - r236299: Disallow conversions from function pointers to void*.
>>    https://github.com/llvm-mirror/libcxxabi/commit/b979db159a515fe12b54f793690618313e017259
>>
>> /Eric
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded



More information about the cfe-commits mailing list