[PATCH] TargetParser prototype - NFC (ARM only)

Renato Golin renato.golin at linaro.org
Fri May 1 11:54:57 PDT 2015

Comment at: include/llvm/Support/ARMTargetParser.h:90-91
@@ +89,4 @@
+class ARMTargetParser {
+  static StringRef getFPUSynonim(StringRef FPU);
+  static StringRef getArchSynonim(StringRef Arch);
john.brawn wrote:
> Synonym.
Oops. :)

Comment at: lib/Support/ARMTargetParser.cpp:157-158
@@ +156,4 @@
+    .Case("vfp4-d16", "vfpv4-d16")
+    .Cases("fp4-sp-d16", "fpv4-sp-d16", "vfpv4-d16")
+    .Cases("fp5-sp-d16", "fpv5-sp-d16", "fpv5-d16")
+    .Case("fp5-dp-d16", "fpv5-d16")
john.brawn wrote:
> The -sp-d16 FP variants aren't synonyms for the -d16 variants. This preserves the current behaviour, where clang -S -mfpu=fpv5-sp-d16 gets you .fpu fpv5-d16 (which doesn't seem right to me), but it could at least do with a comment.
Yes, I'm trying to keep 100% compatibility, so that this doesn't break anything obscure and I have to revert the refactoring. Once the mechanism is in place, it'll be *a lot* easier to make it right in a single place.

I'll add a comment.



More information about the cfe-commits mailing list