[PATCH] [analyzer] Support spaces in compiler path and arguments.

Jordan Rose jordan_rose at apple.com
Thu Apr 30 09:29:21 PDT 2015


Thanks, good catch.


================
Comment at: tools/scan-build/ccc-analyzer:182-186
@@ -181,3 +181,7 @@
   $line =~ s/^\s+|\s+$//g;
   my @items = quotewords('\s+', 0, $line);
+  # Wrap arguments that have spaces with quotes.
+  foreach (@items) {
+    $_ = qq/"$_"/ if (/\s+/);
+  }
   my $cmd = shift @items;
----------------
I think we can just pass `true` to quotewords' 'keep' parameter.

http://reviews.llvm.org/D9357

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list