[PATCH] [cuda] treat file scope __asm as __host__ and ignore it during device-side compilation.

Artem Belevich tra at google.com
Fri Apr 24 15:56:42 PDT 2015


Hi jpienaar, eliben, rnk,

Currently clang emits file-scope asm during *both* host and device compilation modes which is usually a wrong thing to do.

There's no way to attach any attribute to an __asm statement, so there's no way to differentiate between host-side and device-side file-scope asm.
This patch makes clang to match nvcc behavior and emit file-scope-asm only during host-side compilation.

http://reviews.llvm.org/D9270

Files:
  lib/CodeGen/CodeGenModule.cpp
  test/CodeGenCUDA/filter-decl.cu

Index: lib/CodeGen/CodeGenModule.cpp
===================================================================
--- lib/CodeGen/CodeGenModule.cpp
+++ lib/CodeGen/CodeGenModule.cpp
@@ -3356,6 +3356,9 @@
     break;
 
   case Decl::FileScopeAsm: {
+    // File-scope asm is ignored during device-side CUDA compilation.
+    if (LangOpts.CUDA && LangOpts.CUDAIsDevice)
+      break;
     auto *AD = cast<FileScopeAsmDecl>(D);
     getModule().appendModuleInlineAsm(AD->getAsmString()->getString());
     break;
Index: test/CodeGenCUDA/filter-decl.cu
===================================================================
--- test/CodeGenCUDA/filter-decl.cu
+++ test/CodeGenCUDA/filter-decl.cu
@@ -3,6 +3,12 @@
 
 #include "Inputs/cuda.h"
 
+// This has to be at the top of the file as that's where file-scope
+// asm ends up.
+// CHECK-HOST: module asm "file scope asm is host only"
+// CHECK-DEVICE-NOT: module asm "file scope asm is host only"
+__asm__("file scope asm is host only");
+
 // CHECK-HOST-NOT: constantdata = global
 // CHECK-DEVICE: constantdata = global
 __constant__ char constantdata[256];

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9270.24421.patch
Type: text/x-patch
Size: 1096 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150424/718d51fc/attachment.bin>


More information about the cfe-commits mailing list