[PATCH] Fix PR22047: ObjC: Method unavailability attribute doesn't work with overloaded methods

[Jonathan Roelofs]

Hi aaron.ballman,

http://reviews.llvm.org/D9261

Files:
  lib/Sema/SemaDeclObjC.cpp
  test/SemaObjC/multiple-method-names.m

Index: lib/Sema/SemaDeclObjC.cpp
===================================================================
--- lib/Sema/SemaDeclObjC.cpp
+++ lib/Sema/SemaDeclObjC.cpp
@@ -2385,10 +2385,10 @@
   // Diagnose finding more than one method in global pool
   SmallVector<ObjCMethodDecl *, 4> Methods;
   Methods.push_back(BestMethod);
-  for (ObjCMethodList *M = &MethList; M; M = M->getNext())
-    if (M->getMethod() && !M->getMethod()->isHidden() &&
-        M->getMethod() != BestMethod)
-      Methods.push_back(M->getMethod());
+  for (ObjCMethodList *ML = &MethList; ML; ML = ML->getNext())
+    if (ObjCMethodDecl *M = ML->getMethod())
+      if (!M->isHidden() && M != BestMethod && !M->hasAttr<UnavailableAttr>())
+        Methods.push_back(M);
   if (Methods.size() > 1)
     DiagnoseMultipleMethodInGlobalPool(Methods, Sel, R, receiverIdOrClass);
 
@@ -2420,7 +2420,7 @@
                                               bool receiverIdOrClass) {
   // We found multiple methods, so we may have to complain.
   bool issueDiagnostic = false, issueError = false;
-  
+
   // We support a warning which complains about *any* difference in
   // method signature.
   bool strictSelectorMatch =
@@ -2434,7 +2434,7 @@
       }
     }
   }
-  
+
   // If we didn't see any strict differences, we won't see any loose
   // differences.  In ARC, however, we also need to check for loose
   // mismatches, because most of them are errors.
Index: test/SemaObjC/multiple-method-names.m
===================================================================
--- test/SemaObjC/multiple-method-names.m
+++ test/SemaObjC/multiple-method-names.m
@@ -0,0 +1,19 @@
+// RUN: %clang_cc1 -Wobjc-multiple-method-names -x objective-c %s -verify
+// PR22047
+
+ at interface Face0
+- (void)foo:(float)i; // expected-note {{using}}
+ at end
+
+ at interface Face1
+- (void)foo:(int)i __attribute__((unavailable));
+ at end
+
+ at interface Face2
+- (void)foo:(char)i; // expected-note {{also found}}
+ at end
+
+void f(id i) {
+  [i foo:4.0f]; // expected-warning {{multiple methods named 'foo:' found}}
+}
+

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9261.24405.patch
Type: text/x-patch
Size: 2059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150424/2ee15aa4/attachment.bin>