[PATCH] PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file

Tom Honermann thonermann at coverity.com
Wed Apr 22 08:31:43 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: unittests/Serialization/Reserialization.cpp:1
@@ +1,2 @@
+//===- unittests/Serialization/Reserialization.cpp - Reserialization tests ===//
+//
----------------
rsmith wrote:
> I'm not completely sure what "reserialization" means here; I'd expect this to be tests for serializing stuff we'd deserialized (which we generally avoid doing). Maybe something like "Serialization/Decls.cpp" would be a better name for tests of Decl deserialization?
You are right, this could use a better name.  I'm reaching for a term that describes "produce an AST, serialize it, deserialize it, then test it".  I wasn't able to come up with anything better.  Perhaps a term isn't necessary in which case 'Decls.cpp' would be just fine.

http://reviews.llvm.org/D9126

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list