[PATCH] [Parse] Allow 'constexpr' in condition declarations

[Richard Smith]

Thanks!

Marking a declaration as `constexpr` should have no effect on whether it results in odr-uses of other things, so I'm surprised that you're seeing a difference there. What's the testcase, and how does it fail?


================
Comment at: include/clang/Parse/Parser.h:1760
@@ -1760,1 +1759,3 @@
+                                   DeclSpecContext DSC = DSC_normal,
+                                   bool AllowConstexprs = false);
 
----------------
Please add a new DSC value for conditions rather than adding a flag here.

================
Comment at: lib/Sema/SemaExprCXX.cpp:2585
@@ -2584,1 +2584,3 @@
 
+  Condition = MaybeCreateExprWithCleanups(Condition.get());
+
----------------
Do your tests cover the need for this?

================
Comment at: test/CXX/stmt.stmt/stmt.select/p6.cpp:4-5
@@ +3,4 @@
+
+// This test verifies the functionality specified by DR948:
+// http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#948
+
----------------
The right place for such a test is tests/CXX/drs/dr9xx.cpp.

http://reviews.llvm.org/D8978

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/