[cfe-dev] Patch for PR23175, Infinite loop iterating Objective-C method declarations

[Tom Honermann]

Thanks all for following up on this.

I had added comments to the BZ detailing the issue and the patches 
attached.  If those comments are insufficient to explain the issue, how 
I addressed it, or details of the unit test, I'll be happy to add more 
detail.

https://llvm.org/bugs/show_bug.cgi?id=23175

Tom.

On 04/17/2015 09:42 PM, Nikola Smiljanic wrote:
> Two patches are attached in the bug report, fix and unittest. The code
> is tooling related so you seem like a good choice :) I had a look but am
> clueless when it comes to this part of clang.
>
> On Sat, Apr 18, 2015 at 11:40 AM, Manuel Klimek <klimek at google.com
> <mailto:klimek at google.com>> wrote:
>
>     What do I need to do here?
>
>     On Fri, Apr 17, 2015 at 6:34 PM Nikola Smiljanic <popizdeh at gmail.com
>     <mailto:popizdeh at gmail.com>> wrote:
>
>         Adding Klimek to help move this along :)
>
>         On Wed, Apr 15, 2015 at 5:34 AM, Tom Honermann
>         <thonermann at coverity.com <mailto:thonermann at coverity.com>> wrote:
>
>             Removing cfe-dev; CCing cfe-commits and akirtzidis (who svn
>             suggests has previously made changes in this area.  I'm
>             guessing at an email address for akirtzidis).
>
>             Tom.
>
>             On 04/14/2015 03:52 AM, Nikola Smiljanic wrote:
>
>                 Please send patches to cfe-commits or use Phabricator,
>                 they'll just get
>                 lost in the issue tracker. Make sure you CC someone as well.
>
>                 On Tue, Apr 14, 2015 at 12:02 AM, Tom Honermann
>                 <thonermann at coverity.com <mailto:thonermann at coverity.com>
>                 <mailto:thonermann at coverity.com
>                 <mailto:thonermann at coverity.com>>> wrote:
>
>                      Could someone be so kind as to review the patches
>                 attached to
>                      PR23175 and, assuming no concerns, commit them?
>
>                      Bug 23175 - Infinite loop iterating Objective-C
>                 method declarations
>                      in categories when the AST was deserialized from an
>                 .ast file
>                 https://llvm.org/bugs/show___bug.cgi?id=23175
>                      <https://llvm.org/bugs/show_bug.cgi?id=23175>
>
>                      Thank you,
>                      Tom.
>                      _________________________________________________
>                      cfe-dev mailing list
>                 cfe-dev at cs.uiuc.edu <mailto:cfe-dev at cs.uiuc.edu>
>                 <mailto:cfe-dev at cs.uiuc.edu <mailto:cfe-dev at cs.uiuc.edu>>
>                 http://lists.cs.uiuc.edu/__mailman/listinfo/cfe-dev
>                      <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev>
>
>
>
>