[PATCH] [Sema] Don't crash on array types with incomplete element type whose bound results in overflow

Richard Smith richard at metafoo.co.uk
Fri Apr 17 18:46:13 PDT 2015


It's awkward to be rewriting chunks of `Sema::BuildArrayType` here. Would it be possible to factor out the "check for negative bound and array too large, and build a constant array type" part and use it in both places? The callers of `TryToFixInvalidVariablyModifiedType` all apparently want to diagnose those failure conditions in the same way (except that `CheckVariableDeclarationType` apparently chooses to ignore these bits and give a worse diagnostic instead.


http://reviews.llvm.org/D8962

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list