r233860 - [UBSan] Embed UBSan into ASan runtime (Clang part).

[Alexey Samsonov]

Thanks!

On Thu, Apr 9, 2015 at 11:50 AM, Hans Wennborg <hans at chromium.org> wrote:

> On Wed, Apr 1, 2015 at 3:42 PM, Alexey Samsonov <vonosmas at gmail.com>
> wrote:
> > Author: samsonov
> > Date: Wed Apr  1 17:42:25 2015
> > New Revision: 233860
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=233860&view=rev
> > Log:
> > [UBSan] Embed UBSan into ASan runtime (Clang part).
> [..]
> > Modified: cfe/trunk/lib/Driver/ToolChains.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=233860&r1=233859&r2=233860&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/lib/Driver/ToolChains.cpp (original)
> > +++ cfe/trunk/lib/Driver/ToolChains.cpp Wed Apr  1 17:42:25 2015
> > @@ -338,6 +338,9 @@ void DarwinClang::AddLinkSanitizerLibArg
> >                                      OS + "_dynamic.dylib").str(),
> >                      /*AlwaysLink*/ true, /*IsEmbedded*/ false,
> >                      /*AddRPath*/ true);
> > +  // Add explicit dependcy on -lc++abi, as -lc++ doesn't re-export
> > +  // all RTTI-related symbols that UBSan uses.
> > +  CmdArgs.push_back("-lc++abi");
>
> This broke Chromium's ASan build on Darwin, which doesn't use libc++.
> I've tried to fix in r234521.
>
>  - Hans
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150411/3b9729d5/attachment.html>