[PATCH] [OPENMP] Codegen for 'atomic update' construct.

John McCall rjmccall at gmail.com
Fri Mar 27 09:46:51 PDT 2015


Mostly looks great.  One small tweak.


================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:1109
@@ +1108,3 @@
+  auto &C =  CGF.CGM.getContext();
+  llvm::AtomicRMWInst::BinOp Op = llvm::AtomicRMWInst::BAD_BINOP;
+  // Emit atomicrmw only if 'x' and 'expr' are integer values, lvalue for 'x'
----------------
I would split this out as a helper function that returns an Optional<llvm::AtomicRMWInst::BinOp>.

http://reviews.llvm.org/D8536

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list