[PATCH] Command-line options to set debugger "target"

David Blaikie dblaikie at gmail.com
Fri Mar 27 09:25:13 PDT 2015


================
Comment at: test/Driver/debug-options.c:32
@@ +31,3 @@
+
+// RUN: %clang -### -c -g %s -target x86_64-scei-ps4 2>&1 \
+                    | FileCheck -check-prefix=G -check-prefix=G_SCE %s
----------------
Given that -g<debugger> and -g<debug level> are orthogonal (they are, right? Judging by your change they look orthogonal) we don't need to test all the combinations of them. I'd either just test them separately (g1, g2, g3, ggdb, glldb, gsce) or if want to really try to minimize the number of test cases, test them in ad-hoc pairs (g1+ggdb, g2+glldb, etc.) - though that can make things a bit harder to maintain later on (trying to decide if the pairing is significant or not, etc).

http://reviews.llvm.org/D8599

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list