[PATCH] Fix coverage-ld.c on systems with an Android linker in $PATH

Ehsan Akhgari ehsan.akhgari at gmail.com
Tue Mar 24 18:04:35 PDT 2015


Hi samsonov,

On my system, clang tries to invoke /path/to/arm-linux-androideabi-ld
as the linker for Android, and the regex inside the test file considers
this as unacceptable.

http://reviews.llvm.org/D8598

Files:
  test/Driver/coverage-ld.c

Index: test/Driver/coverage-ld.c
===================================================================
--- test/Driver/coverage-ld.c
+++ test/Driver/coverage-ld.c
@@ -33,5 +33,5 @@
 // RUN:     --sysroot=%S/Inputs/basic_android_tree/sysroot \
 // RUN:   | FileCheck --check-prefix=CHECK-ANDROID-ARM %s
 //
-// CHECK-ANDROID-ARM: "{{(.*[^-.0-9A-Z_a-z])?}}ld{{(.exe)?}}"
+// CHECK-ANDROID-ARM: "{{(.*[^.0-9A-Z_a-z])?}}ld{{(.exe)?}}"
 // CHECK-ANDROID-ARM: "{{.*}}/Inputs/resource_dir{{/|\\\\}}lib{{/|\\\\}}linux{{/|\\\\}}libclang_rt.profile-arm-android.a"

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8598.22623.patch
Type: text/x-patch
Size: 552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150325/8bf66f90/attachment.bin>


More information about the cfe-commits mailing list