r233109 - Removing a CHECK that is about to go wrong.

Sanjay Patel spatel at rotateright.com
Tue Mar 24 13:35:24 PDT 2015


Author: spatel
Date: Tue Mar 24 15:35:24 2015
New Revision: 233109

URL: http://llvm.org/viewvc/llvm-project?rev=233109&view=rev
Log:
Removing a CHECK that is about to go wrong.

I'm about to commit a patch for:
http://reviews.llvm.org/D8567

That patch will break this one existing test case in Clang.
I'm not sure if this file is intending to create a Clang
dependency on the LLVM IR optimizer, but that's the
consequence of specifying -O3 on this test file.

My hope is to avoid buildbot rage by removing this check,
committing the LLVM patch, and then fixing this check.
I don't know how to make a simultaneous commit to Clang
and LLVM.

I will commit the correct CHECK line fix for this test 
shortly.

Modified:
    cfe/trunk/test/CodeGen/avx-shuffle-builtins.c

Modified: cfe/trunk/test/CodeGen/avx-shuffle-builtins.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/avx-shuffle-builtins.c?rev=233109&r1=233108&r2=233109&view=diff
==============================================================================
--- cfe/trunk/test/CodeGen/avx-shuffle-builtins.c (original)
+++ cfe/trunk/test/CodeGen/avx-shuffle-builtins.c Tue Mar 24 15:35:24 2015
@@ -53,8 +53,7 @@ __m256d test_mm256_permute2f128_pd(__m25
 }
 
 __m256 test_mm256_permute2f128_ps(__m256 a, __m256 b) {
-  // Check if the mask is correct
-  // CHECK: shufflevector{{.*}} <8 x i32> <i32 12, i32 13, i32 14, i32 15, i32 4, i32 5, i32 6, i32 7>
+  // FIXME: Check if the mask is correct
   return _mm256_permute2f128_ps(a, b, 0x13);
 }
 





More information about the cfe-commits mailing list