r232793 - [modules] Remove some redundant work when building a lookup table for a DeclContext.

Richard Smith richard at metafoo.co.uk
Sun Mar 22 20:29:57 PDT 2015


On Sun, Mar 22, 2015 at 1:55 AM, Vince Harron <vince at nethacker.com> wrote:

> In for a dime, in for a dollar.
>
> When 232793 was reverted, Clang::redecl-add-after-load.cpp began failing
> everywhere.
>
> I also reverting 232853 and 232870 to fix Clang::redecl-add-after-load.cpp
> (because they depend on 232793)
>
> Sorry for all the hassle Richard, I just don't know how long this will
> take to sort out and I don't want more errors to pile in unnoticed.
>

Thanks for the revert (yes, this is consistent with our policy, but please
remember to run the tests before committing in future). I've fixed the
issue and re-committed the reverted patches as r232928.


> Thanks,
>
> Vince
>
>
>
>
> On Sat, Mar 21, 2015 at 11:08 PM, Vince Harron <vince at nethacker.com>
> wrote:
>
>> Hi Richard,
>>
>> I've reverted this patch.  (I hope that's consistent with project
>> policy.)  Can you please investigate the LLDB failures is causes before
>> resubmitting?  Please let us know if we can be of any help.  For all I
>> know, the patch just exposes a bug in LLDB.
>>
>> Sincerely,
>>
>> Vince
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150322/13fdd53a/attachment.html>


More information about the cfe-commits mailing list