[PATCH] Don't claim exception related arguments when looking at RTTIMode

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Fri Mar 20 15:46:26 PDT 2015

Hi rsmith, samsonov,

We were claiming the -f*exceptions arguments when looking for the
RTTIMode. This makes us not warn about unused arguments if compiling a C
file with -fcxx-exceptions.

This patch fixes it by not claiming the exception-related arguments at
that point.



Index: lib/Driver/ToolChain.cpp
--- lib/Driver/ToolChain.cpp
+++ lib/Driver/ToolChain.cpp
@@ -48,7 +48,7 @@
   // On the PS4, turning on c++ exceptions turns on rtti.
   // We're assuming that, if we see -fexceptions, rtti gets turned on.
-  Arg *Exceptions = Args.getLastArg(
+  Arg *Exceptions = Args.getLastArgNoClaim(
       options::OPT_fcxx_exceptions, options::OPT_fno_cxx_exceptions,
       options::OPT_fexceptions, options::OPT_fno_exceptions);
   if (Exceptions &&
Index: test/Driver/rtti-options.cpp
--- test/Driver/rtti-options.cpp
+++ test/Driver/rtti-options.cpp
@@ -3,6 +3,10 @@
 // No warnings/errors should be emitted for unknown, except if combining
 // the vptr sanitizer with -fno-rtti
+// Special case: -fcxx-exceptions in C code should warn about unused arguments
+// RUN: %clang -### -c -fcxx-exceptions %s 2>&1 | FileCheck -check-prefix=CHECK-UNUSED %s
+// CHECK-UNUSED: warning: argument unused during compilation: '-fcxx-exceptions'
 // RUN: %clang -### -c -fno-rtti -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-RTTI %s
 // RUN: %clang -### -c -frtti -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-NO-RTTI %s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8507.22392.patch
Type: text/x-patch
Size: 1285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150320/4fca5ea8/attachment.bin>

More information about the cfe-commits mailing list