[PATCH] Fix source range of defaulted/deleted member declarations

Eli Bendersky eliben at google.com
Fri Mar 20 12:37:30 PDT 2015


In http://reviews.llvm.org/D8465#144236, @rnk wrote:

> It doesn't look too hard to do this locally in ParseCXXInlineMethodDef by saving the end of the current token location before calling `TryConsumeToken`:
>
>   SourceLocation KWEndLoc = Tok.getEndLoc();
>   if (TryConsumeToken(...)) {
>     ...
>     FnD->setRangeEnd(KWEndLoc);
>   } else if (TryConsumeToken(...)) {
>     ...
>     FnD->setRangeEnd(KWEndLoc);
>   }
>   
>
> Seem reasonable?


Ah, indeed. This makes things simpler. PTAL

Thanks


http://reviews.llvm.org/D8465

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list