[PATCH] Ensure that we still parse preprocessed CUDA files as CUDA when we use-save-temps option.

Eric Christopher echristo at gmail.com
Wed Mar 18 16:09:12 PDT 2015


Much better, some inline comments.

Thanks!

-eric


================
Comment at: test/Driver/cuda-simple.cu:5
@@ +4,3 @@
+//
+// We can't use -fsyntax-only with -save-temps because it would create
+// a temporary file after preprocessor stage. Instead we'll verify that we
----------------
Probably best to avoid most of this comment and just say what you're testing here.

================
Comment at: test/Driver/cuda-simple.cu:21
@@ +20,3 @@
+
+// CHECK: "-cc1"
+// CHECK: "-E"
----------------
Can you move these up by the test that they're from?

http://reviews.llvm.org/D8383

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list