r232631 - OpenCL: CL2.0 atomic types

Anastasia Stulova anastasia.stulova at arm.com
Wed Mar 18 09:58:40 PDT 2015

The proper fix for this is attached. It was too unsafe to rely on the target type mapping, since for each architecture types are mapped differently. In this case for 32 bit archs ptr types are mapped to normal int, therefore the check didn't work correctly. So I am now just using the type names instead of checking created type. 

This implementation doesn't rely on any target information and therefore should work similarly for all architectures now. Just tested for x86 and hexagon and it worked.

If it's ok, I can commit the fix now.

I am adding Pekka here as the original reviewer of this patch.

Thanks for help!

-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 18 March 2015 16:19
Cc: Anastasia Stulova; cfe-commits
Subject: Re: r232631 - OpenCL: CL2.0 atomic types

On 18 March 2015 at 15:40, Renato Golin <renato.golin at linaro.org> wrote:
> Thanks, it was also failing on ARM. I'll check if your fix also worked 
> there when it passes.

It did. Cheers!

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cl20_atomics_architecture_agnostic_fix.txt
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150318/da69fccb/attachment.txt>

More information about the cfe-commits mailing list