[PATCH] Pass -mglobal-merge as a module flag metadata.

Ahmed Bougacha ahmed.bougacha at gmail.com
Tue Mar 17 18:31:55 PDT 2015


I'm not sure I entirely follow, but these issues with Subtargets and
friends are orthogonal to the GlobalMerge thing, right?
Here, if the flags conflict, the "-mno-global-merge" wins, so Module
Flags seem like a perfect fit, even though I gather they're not for
target features and CPUs and such.
-Ahmed


On Fri, Mar 13, 2015 at 3:23 PM, Eric Christopher <echristo at gmail.com> wrote:
> Hrm. What do you think about requiring that flags like this for LTO are just required to be passed on the command line rather than left in the module and subject to module merge? If so, you can just pass the option to the backend via TargetOptions which will put it on the TargetMachine and make it easy to grab for the pass manager.
>
> Thoughts?
>
> -eric
>
>
> http://reviews.llvm.org/D7968
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>




More information about the cfe-commits mailing list