[PATCH] libc++abi: Make the .eh_frame_hdr code work on FreeBSD and CloudABI as well

Ed Schouten ed at nuxi.nl
Mon Mar 16 23:19:27 PDT 2015


Comment at: src/Unwind/AddressSpace.hpp:71
@@ -63,1 +70,3 @@
+#define ElfW3(width, type) Elf##width##_##type
 #include "EHHeaderParser.hpp"
compnerd wrote:
> Hmm..Im not sure that this is the best way to approach this.  What if you want to do remote unwinding, where your host is 32-bit and your remote is 64-bit or vice-versa.  This breaks in that case, as you are using `__INTPTR_WIDTH__`.  Or am I overlooking something?
This piece of code always has to be executed on the target. This macro is simply needed to fulfil the contract of `dl_iterate_phdr()`. This function is executed on the target system to obtain the address of the ELF program headers of the running process.

Using a width unequal to `__INTPTR_WIDTH__` wouldn't make any sense. In fact, it would only generate compiler errors, for the reason that `struct dl_phdr_info::dlpi_phdr` is defined as a `const ElfW(Phdr) *`. See the following man page for details:




More information about the cfe-commits mailing list